Skip to content

Never change the underlying string encoding#132

Closed
jeremyevans wants to merge 2 commits intoruby:masterfrom
jeremyevans:never-set-underlying-encoding
Closed

Never change the underlying string encoding#132
jeremyevans wants to merge 2 commits intoruby:masterfrom
jeremyevans:never-set-underlying-encoding

Conversation

@jeremyevans
Copy link
Contributor

StringIO should be a view of given source string and set_encoding shouldn't change source encoding.

Similar change for binmode and set_encoding_by_bom.

StringIO should be a view of given source string and
set_encoding shouldn't change source encoding.

Similar change for binmode and set_encoding_by_bom.
@jeremyevans
Copy link
Contributor Author

Closing, will go with approach in #128 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant