Skip to content

Enable tests passing on TruffleRuby #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Feb 24, 2025
+2 −31
Merged

Enable tests passing on TruffleRuby #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0e8a8
Enable tests passing on TruffleRuby
andrykonchin Feb 24, 2025
cc0dead
Remove truffleruby and keep only truffleruby-head in CI
andrykonchin Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ jobs:
- { os: macos-latest , ruby: 2.4 }
- { os: macos-latest , ruby: 2.5 }
- { os: windows-latest , ruby: head }
- { os: ubuntu-latest , ruby: truffleruby }
- { os: macos-latest , ruby: truffleruby }
- { os: windows-latest , ruby: truffleruby }
- { os: windows-latest , ruby: truffleruby-head }

Expand Down
31 changes: 0 additions & 31 deletions test/strscan/test_stringscanner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

module StringScannerTests
def test_peek_byte
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('ab')
assert_equal(97, s.peek_byte)
assert_equal(97, s.scan_byte)
Expand All @@ -20,7 +19,6 @@ def test_peek_byte
end

def test_scan_byte
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('ab')
assert_equal(2, s.match?(/(?<a>ab)/)) # set named_captures
assert_equal(97, s.scan_byte)
Expand Down Expand Up @@ -178,7 +176,6 @@ def test_bol?
end

def test_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('test string')
assert_equal('test string', s.string)
s.scan(/(?<t>test)/) # set named_captures
Expand Down Expand Up @@ -370,7 +367,6 @@ def test_skip_with_begenning_of_line_anchor_match
end

def test_getch
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('abcde')
assert_equal(3, s.match?(/(?<a>abc)/)) # set named_captures
assert_equal('a', s.getch)
Expand All @@ -392,7 +388,6 @@ def test_getch
end

def test_get_byte
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('abcde')
assert_equal(3, s.match?(/(?<a>abc)/)) # set named_captures
assert_equal('a', s.get_byte)
Expand Down Expand Up @@ -439,7 +434,6 @@ def test_matched
end

def test_matched_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('stra strb strc')
s.scan('stra')
assert_equal('stra', s.matched)
Expand Down Expand Up @@ -570,7 +564,6 @@ def test_pre_match
end

def test_pre_match_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('a b c d e')
s.scan('a')
assert_equal('', s.pre_match)
Expand Down Expand Up @@ -615,7 +608,6 @@ def test_post_match
end

def test_post_match_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('a b c d e')
s.scan('a')
assert_equal(' b c d e', s.post_match)
Expand All @@ -636,7 +628,6 @@ def test_post_match_string
end

def test_terminate
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('abcd')
s.scan(/(?<a>ab)/) # set named_captures
s.terminate
Expand All @@ -647,7 +638,6 @@ def test_terminate
end

def test_reset
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('abcd')
s.scan(/(?<a>ab)/) # set named_captures
s.reset
Expand Down Expand Up @@ -704,8 +694,6 @@ def test_encoding_string
end

def test_invalid_encoding_string
omit("no encoding check on TruffleRuby for scan(String)") if RUBY_ENGINE == "truffleruby"

str = "\xA1\xA2".dup.force_encoding("euc-jp")
ss = create_string_scanner(str)
assert_raise(Encoding::CompatibilityError) do
Expand Down Expand Up @@ -775,7 +763,6 @@ def test_exist_p_invalid_argument
end

def test_exist_p_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner("test string")
assert_equal(3, s.exist?("s"))
assert_equal(0, s.pos)
Expand All @@ -797,7 +784,6 @@ def test_scan_until
end

def test_scan_until_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner("Foo Bar\0Baz")
assert_equal("Foo", s.scan_until("Foo"))
assert_equal(3, s.pos)
Expand All @@ -821,7 +807,6 @@ def test_skip_until
end

def test_skip_until_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner("Foo Bar Baz")
assert_equal(3, s.skip_until("Foo"))
assert_equal(3, s.pos)
Expand All @@ -840,7 +825,6 @@ def test_check_until
end

def test_check_until_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner("Foo Bar Baz")
assert_equal("Foo", s.check_until("Foo"))
assert_equal(0, s.pos)
Expand All @@ -862,7 +846,6 @@ def test_search_full
end

def test_search_full_string
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner("Foo Bar Baz")
assert_equal(8, s.search_full("Bar ", false, false))
assert_equal(0, s.pos)
Expand All @@ -886,7 +869,6 @@ def test_peek
end

def test_unscan
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
s = create_string_scanner('test string')
assert_equal(4, s.skip(/(?<t>test)/)) # set named_captures
s.unscan
Expand Down Expand Up @@ -923,8 +905,6 @@ def test_inspect2
end

def test_aref_without_regex
omit "#[:missing] always raises on TruffleRuby if matched" if RUBY_ENGINE == "truffleruby"

s = create_string_scanner('abc')
s.get_byte
assert_raise(IndexError) { s[:c] }
Expand Down Expand Up @@ -979,7 +959,6 @@ def test_scan_aref_repeatedly
end

def test_named_captures
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"
scan = StringScanner.new("foobarbaz")
assert_equal({}, scan.named_captures)
assert_equal(9, scan.match?(/(?<f>foo)(?<r>bar)(?<z>baz)/))
Expand All @@ -989,8 +968,6 @@ def test_named_captures
end

def test_scan_integer
omit("scan_integer isn't implemented on TruffleRuby yet") if RUBY_ENGINE == "truffleruby"

s = create_string_scanner('abc')
assert_equal(3, s.match?(/(?<a>abc)/)) # set named_captures
assert_nil(s.scan_integer)
Expand Down Expand Up @@ -1026,8 +1003,6 @@ def test_scan_integer
end

def test_scan_integer_unmatch
omit("scan_integer isn't implemented on TruffleRuby yet") if RUBY_ENGINE == "truffleruby"

s = create_string_scanner('123abc')
assert_equal(123, s.scan_integer)
assert_equal(3, s.pos)
Expand All @@ -1037,17 +1012,13 @@ def test_scan_integer_unmatch
end

def test_scan_integer_encoding
omit("scan_integer isn't implemented on TruffleRuby yet") if RUBY_ENGINE == "truffleruby"

s = create_string_scanner('123abc'.encode(Encoding::UTF_32LE))
assert_raise(Encoding::CompatibilityError) do
s.scan_integer
end
end

def test_scan_integer_matched
omit("not implemented on TruffleRuby") if RUBY_ENGINE == "truffleruby"

s = create_string_scanner("42abc")
assert_equal(42, s.scan_integer)
assert_equal("42", s.matched)
Expand All @@ -1058,8 +1029,6 @@ def test_scan_integer_matched
end

def test_scan_integer_base_16
omit("scan_integer isn't implemented on TruffleRuby yet") if RUBY_ENGINE == "truffleruby"

s = create_string_scanner('0')
assert_equal(0x0, s.scan_integer(base: 16))
assert_equal(1, s.pos)
Expand Down