Remove Oracle Instant Client from Dockerfiles; Fix #419#421
Open
Geogouz wants to merge 1 commit intorucio:masterfrom
Open
Remove Oracle Instant Client from Dockerfiles; Fix #419#421Geogouz wants to merge 1 commit intorucio:masterfrom
Geogouz wants to merge 1 commit intorucio:masterfrom
Conversation
rdimaio
approved these changes
Jul 17, 2025
Contributor
rdimaio
left a comment
rdimaio
left a comment
There was a problem hiding this comment.
LGTM. On the backwards compatibility point: I think it's fine to remove the instant client from the latest versions of these containers, as they match the latest changes in the Rucio core code. That said, since 38 will be an LTS release, it might be worth keeping the instant client as part of this release at least, and then removing it from subsequent releases. @bari12 thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Oracle Instant Client and dependencies that have been specified as required by it only.
The affected containers are:
daemonsinitprobesserveruihowever, would we prefer to keep the client in some of those for backwards compatibility (e.g. in
probes)? Not sure. If so, I can leave it (may adding an inline comment that this needs to be removed in 2 years).