Install cron into the probes container, allow switching between cron …#443
Open
ericvaandering wants to merge 1 commit intorucio:masterfrom
Open
Install cron into the probes container, allow switching between cron …#443ericvaandering wants to merge 1 commit intorucio:masterfrom
ericvaandering wants to merge 1 commit intorucio:masterfrom
Conversation
…and jobber, and add a script to deterministically delay running a command
Contributor
Author
|
Part of the fix to rucio/probes#152 along with rucio/helm-charts#303 |
rdimaio
approved these changes
Oct 17, 2025
Comment on lines
+53
to
+56
| print("STDOUT") | ||
| print(executed.stdout) | ||
| print("STDERR") | ||
| print(executed.stderr) |
Contributor
There was a problem hiding this comment.
Could be useful to specify in the prints (maybe we should use a logger instead?) that these are the stdout and err of this probe in particular
Member
There was a problem hiding this comment.
Agreed, can we still change that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and jobber, and add a script to deterministically delay running a command
This is accompanied by changes (no PR yet) in the helm chart. I'd propose this for Rucio 39, I think.
@dchristidis I know you've said you don't rely on this container (and no one but CMS does) but it'd still be good to have a quick look from someone.