Conversation
|
Overall all these changes are really good!! Only thing I didn't comment on directly in the body of the review is that we might want to mention how rse specific limits work vs account only limits |
|
@voetberg Added a few fixes in 317c0db. Also, I stumbled upon https://rucio.github.io/documentation/operator/configuration/#creating-new-rses; should I add a link to there pointing to this page? |
I would say this PR completely supersedes that page, and I would link to this page and drastically reduce what's on the config params page. (Maybe just summarizing into a TL;DR with "add rse", "add rse attribute", "add rse protocol", "add account limit") If you would like, I can take that over and you can just link your page there with something like "An in-depth guide to configuring RSEs can be found here" |
Cool, then I'll let you take care of the summary, while I'll just link this page in there. As soon as I have some info about |
|
@Soap2G , there seem to be existing section in doc title "Creating new RSEs" Quota stuff is also discussed in here: https://rucio.cern.ch/documentation/operator/configuration/#setting-quota-and-permissions We should consolidate the two and have a single place to have these information. So I would think: |
See this comment; Maggie will take care of that once the page is up. |
|
@voetberg @panta-123 We should be ready to go, with the reminder of merging the redundant RSE-related pages after this is done. |
|
@Soap2G Please rebase to grab the pre-commit ci! |
Documentation on setting up and configuring Rucio Storage Elements (RSEs) from an operator's perspective. Includes: - Overview of RSE types (POSIX, WebDAV, Disk, Tape) - Two setup methods: CLI and Python API with side-by-side examples - Configuration examples for each RSE type - WebDAV setup with Apache configuration and davs protocol - EOS disk RSE with https and root protocols - CTA tape RSE configuration with staging timeouts - RSE attributes, protocols, and account limits reference - Best practices and common pitfalls - Quick reference commands The examples use the latest `rucio` CLI commands Co-authored-by: Nikita Avdeev <naavdeev.astro@gmail.com> Co-authored-by: Luis Antonio Obis Aparicio <luis.antonio.obis@gmail.com>
…nstead of core Used RSEClient class for rse operations, and AccountLimitClient for account. Additionally added a paragraph about configuration concepts.
Removed istape from RSE config guide, as it's not needed by Rucio and it can be replaced by rse_type. Additionally, added a clearer description of istape in the attributes page.
d46af70 to
f80b901
Compare
voetberg
left a comment
There was a problem hiding this comment.
lgtm - nothing seems obviously wrong and if people want to add more examples we can do that in the future
|
@panta-123 Do you want to give this a read-over and review? |
This commit consolidates multiple documentation corrections and clarifications: - Corrected RSE settings vs attributes distinction - Fixed TypedDict field listings to match actual implementation - Removed non-existent protocol priority fields (priority_lan, priority_wan) - Clarified that lfn2pfn_algorithm is an RSE attribute, not a creation parameter - Restored geographic fields (city, country_name, latitude, longitude, region_code, time_zone) as valid RSE settings that can be set via gateway API - Clarified deterministic vs non-deterministic RSE behavior - lfn2pfn_algorithm: for deterministic RSEs (disk), computes paths from scope+name only - naming_convention: for non-deterministic RSEs (tape), uses metadata/timestamps - Added detailed comparison table explaining the differences - Updated all examples to reflect correct usage patterns - Fixed Python API examples** - Removed incorrect lfn2pfn_algorithm parameter from add_rse() calls - Shows correct attribute-based configuration via add_rse_attribute() - Updated workflow examples to match actual client implementation - CLI fixes - Minor fixes to commands structure
|
Thanks to @Geogouz for the AI-assisted review. It was very useful to spot some inconsistencies in the text. I've also slightly updated Reviews are welcome @voetberg @panta-123 |
At Rucio's service upon request :D. For reference, here is what the output was in case others would like to use it too in the future. May not be perfect, but I would say it clearly does more good than harm to have it as an additional review opinion: 1) “RSE Attributes” section mixes up settings vs attributesInaccurate / misleading in the guide
What’s correct
Why this matters: setting 2) The “Mandatory attributes” danger box is incorrectInaccurate
What’s correct
3) Protocol priority rules in the guide are wrong / misleadingInaccurate
Misleading / needs tightening
What’s correct directionally
4) CLI examples don’t match the current
|
Closes #709
Documentation on setting up and configuring Rucio Storage Elements (RSEs) from an operator's perspective. Includes:
Overview of RSE types (POSIX, WebDAV, Disk, Tape)(removed in f80b901)WebDAV setup with Apache configuration and davs protocol(removed in 040ee73)The examples use the latest
rucioCLI commands