Common: Update check_expired_dids to use PrometheusPusher, updated SLQA2.0 guidelines#143
Common: Update check_expired_dids to use PrometheusPusher, updated SLQA2.0 guidelines#143voetberg wants to merge 1 commit intorucio:masterfrom
Conversation
voetberg
force-pushed
the
129-update-expired-dids
branch
from
4042f91 to
c5a6bb7
Compare
voetberg
force-pushed
the
129-update-expired-dids
branch
from
9483cf3 to
60ec26a
Compare
dchristidis
left a comment
dchristidis
left a comment
There was a problem hiding this comment.
Please also address these:
check_expired_dids:43:60: W291 trailing whitespace
check_expired_dids:49:1: W293 blank line contains whitespace
Then I would either merge into a single commit or split based on objective (from what I can see: Python 2 compatibility, header, SQLAlchemy, Prometheus, except statement). Just make sure to prefix all commit subjects with Common: .
voetberg
force-pushed
the
129-update-expired-dids
branch
from
60ec26a to
96bbc6c
Compare
dchristidis
left a comment
dchristidis
left a comment
There was a problem hiding this comment.
The content is perfect. Well done.
But I’m afraid I must pester you one last time about the commit message. It’s not considered a good practise to have overly-long subjects. Keep it short and elaborate in the body.
voetberg
force-pushed
the
129-update-expired-dids
branch
from
96bbc6c to
f6188e3
Compare
dchristidis
left a comment
dchristidis
left a comment
There was a problem hiding this comment.
Looks good, thanks for bearing with me.
Following the contribution guide, I need approval from @ericvaandering before I can merge.
Eric is on vacation until next week so we'll have to wait. I already talked with him about this anyways so I assume it'll just be a formality. |
common/check_expired_dids
Outdated
|
|
||
| with PrometheusPusher() as manager: | ||
| (manager.gauge( | ||
| "expired_dids.total", |
There was a problem hiding this comment.
Requires further review.
There was a problem hiding this comment.
What is the "requires further review?"
There was a problem hiding this comment.
Same as the other two PRs: (1) it silently changes the metric name to (2) one that is arguably inferior.
I assume the content-wise this is the exact same as #132 except for possibly some different SQLAlchemy grammar? |
Yeah it's completely identical besides for the sql2.0 and some minor formatting/spacing/indenting |
|
I approve. Can be merged. |
voetberg
changed the title
voetberg
force-pushed
the
129-update-expired-dids
branch
from
f6188e3 to
1db325d
Compare
|
@dchristidis Reverted the name change and added a probe_metrics gauge. Should be fine. |
|
Does this run for you? On my side it fails with an exception. |
* Update to sqla2.0 * push with PrometheusPusher * sort imports * add header * change except statement to except Exception
voetberg
force-pushed
the
129-update-expired-dids
branch
from
1db325d to
0384ff0
Compare
Right you are. I missed testing it again after renaming the gauge. Corrected now. |
|
But then, I’m afraid, we come to the problem that |
3 participants
I'm redoing all of PR #132 with the updated sqla guidelines