Skip to content

Common: Rewrite check_stuck_rules#146

Closed
voetberg wants to merge 1 commit intorucio:masterfrom
voetberg:129-modern-check-stuck-rules
Closed

Common: Rewrite check_stuck_rules#146
voetberg wants to merge 1 commit intorucio:masterfrom
voetberg:129-modern-check-stuck-rules

Conversation

@voetberg
Copy link
Contributor

@voetberg voetberg commented Aug 6, 2024

  • Change gauge to PrometheusPusher
  • update to sqla2.0
  • sort imports
  • update header
  • change except to except Exception

Updated queries compile as (using the dev tables as an example)

SELECT count(*) AS count_1 
FROM dev.rules 
WHERE dev.rules.state = :state_1 AND (dev.rules.error != :error_1 OR dev.rules.error IS NULL)
SELECT count(*) AS count_1 
FROM dev.rules 
WHERE dev.rules.state = :state_1 AND dev.rules.error = :error_1

@voetberg voetberg requested a review from dchristidis as a code owner August 6, 2024 14:43
@voetberg voetberg changed the title Common: Rewrite check_stuck_rules - change gauge to PrometheusPusher,… Common: Rewrite check_stuck_rules Aug 6, 2024
* change gauge to PrometheusPusher
* update to sqla2.0
* sort import
* change header
* Change except to except Exception
@voetberg voetberg force-pushed the 129-modern-check-stuck-rules branch from f851d69 to 3c38ccf Compare August 6, 2024 15:18
@voetberg voetberg added the Common label Aug 6, 2024
@voetberg voetberg self-assigned this Aug 20, 2024
@voetberg
Copy link
Contributor Author

Closing in favor of #162

@voetberg voetberg closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant