Hypens replaced on monitor.record_gauge() function

[FernandoGarzon]

No description provided.

[ericvaandering]

@dchristidis want to take a look at this? It does rename some metrics but I think that's necessary with the new record_gauge which is prometheus compatible. The current code does not work with the latest Rucio as stat is renamed to "name"

[dchristidis]

We’ll need to evaluate the effect of the metrics being renamed on ATLAS before merging this.

Does it mean that you’re planning to move away from Prometheus Pushgateway and rely entirely on Rucio’s monitor.py and regular scraping?

[ericvaandering]

No, but unfortunately the monitor method now ALSO has to be compatible with Prometheus names. That’s the way I understand it. But scraping will not work since the probes are ephemeral. The other option would be something that explicitly skips prometheus in the monitor methods. In fact, longer term I’d like to see us get rid of the probes calling monitor at all and just use bare prometheus.

…

On May 6, 2022, at 6:55 AM, Dimitrios Christidis ***@***.***> wrote: We’ll need to evaluate the effect of the metrics being renamed on ATLAS before merging this. Does it mean that you’re planning to move away from Prometheus Pushgateway and rely entirely on Rucio’s monitor.py and regular scraping? — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rucio_probes_pull_97-23issuecomment-2D1119537984&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=EHaoB-POFWGrYFvPXoj1bQ&m=g6i3XBOxGrnylAARz8fiakbIOsKPOsAPnBH6DioWtso2b4VT6tZR9przMTMMi7Q0&s=bRigWmohTAZ5zvrpAzpSf2hFiL-dlpGfYI5c8TUU24Y&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAMYJLWS2E46NIDU6MIYNLLVIUCE5ANCNFSM5VGJ4NBA&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=EHaoB-POFWGrYFvPXoj1bQ&m=g6i3XBOxGrnylAARz8fiakbIOsKPOsAPnBH6DioWtso2b4VT6tZR9przMTMMi7Q0&s=qVPP6dBSnTAJh6orQe-qkH_BeEoPbyKs3yjQ7XbGdoY&e=>. You are receiving this because you commented.

[FernandoGarzon]

Can we merge this one? Should I use PrometheusPusher here?

[voetberg]

Should we close this? The changes are overwritten by #147

[dchristidis]

Yes, I believe so. I’m not sure whether hyphens are problematic anymore. Should it prove to be the case, we can address it after the other PR is merged.