Skip to content

Add priority sorting for rule and lock states #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maany merged 2 commits into from
Jan 21, 2026
Merged

Add priority sorting for rule and lock states #692

maany merged 2 commits into from
Jan 21, 2026

Conversation

@maany
Copy link
Member

@maany maany commented Jan 21, 2026 •
edited
Loading

Changes

State Comparators

  • Add ruleStateComparator: Sorts rule states by priority (STUCK > SUSPENDED > REPLICATING > WAITING_APPROVAL > INJECT > OK > UNKNOWN)
  • Add lockStateComparator: Sorts lock states by priority (ERROR > STUCK > REPLICATING > OK > UNKNOWN)
  • Add remainingLifetimeComparator: Numeric sorting for remaining lifetime values (applied to DID rules table)

Tables Updated

  • Rules List: Default sort by state, showing stuck/error rules first
  • DID Rules Table: Default sort by state, added remaining lifetime numeric sorting
  • Rule Locks Table: Default sort by state, showing error/stuck locks first

DID Search Panel

  • Fix arrow key navigation in scope/name input fields
  • Arrow keys now move cursor within the current field during typing
  • Only switch between fields when cursor is at edge position (right arrow at end of scope, left arrow at beginning of name)

Benefits

  • Error and stuck states appear first in all rule tables
  • Users can quickly identify problematic rules and replicas
  • Consistent sorting behavior across all rule-related tables
  • Numeric sorting for time values (19 hours sorts before 5 days)
  • Natural text input behavior with arrow keys in DID search

Closes

maany added 2 commits January 21, 2026 15:34
@maany
feat(rules): add priority sorting for rule and lock states
accd6ca 
Add state comparators and default sorting for all rule tables:

- Add ruleStateComparator: STUCK > SUSPENDED > REPLICATING > WAITING_APPROVAL > INJECT > OK > UNKNOWN
- Add lockStateComparator: ERROR > STUCK > REPLICATING > OK > UNKNOWN
- Apply to Rules List table (state sort by default)
- Apply to DID Rules table (state sort by default, add remaining lifetime sort)
- Apply to Rule Locks table (state sort by default)

This ensures error and stuck states appear first across all tables,
helping users quickly identify problematic rules and replicas.
@maany
fix(search): improve arrow key navigation in DID search panel
004ea63 
- Arrow keys now move cursor within input field
- Only switch between fields when cursor is at edge position
- Right arrow switches from scope to name when at end of text
- Left arrow switches from name to scope when at beginning
@maany maany merged commit 3cc9e4d into master Jan 21, 2026
8 checks passed
@maany maany deleted the sorting-improvements branch January 21, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable sorting by lock states in rule tables

2 participants

@maany