Skip to content

Fix access checks and update token command alias #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rulasg merged 3 commits into from
Sep 4, 2025
Merged

Fix access checks and update token command alias #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c06f22
fix: Remove unnecessary null check for result in Test-RepoAccess func…
rulasg Jul 16, 2025
6d439cf
fix: Update getToken alias to use 'gh auth token' command
rulasg Jul 16, 2025
2d31a5e
fix: test mock
rulasg Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Test/public/RepoIssueTimeTracking.test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function Test_GetRepoIssueTimeTracking_Pipe
{
Reset-InvokeCommandMock

$owner = "rulasgorgkk" ; $repo = "repo1" ; $attributes = "title,comments,url" ; $attributes2 = "number,title,url"
$owner = "rulasgorgkk" ; $repo = "repo1" ; $attributes = "title,comments,url" ; $attributes2 = "number,title,state,url"

MockCall -Command "gh issue list -R $owner/$repo --json $attributes2" -filename getIssueList.json

Expand Down Expand Up @@ -186,7 +186,7 @@ function Test_GetRepoIssueTimeTrackingRecords_Pipe
{
Reset-InvokeCommandMock

$owner = "rulasgorgkk" ; $repo = "repo1" ; $attributes = "title,comments,url" ; $attributes2 = "number,title,url"
$owner = "rulasgorgkk" ; $repo = "repo1" ; $attributes = "title,comments,url" ; $attributes2 = "number,title,state,url"

MockCall -Command "gh issue list -R $owner/$repo --json $attributes2" -filename getIssueList.json

Expand Down
2 changes: 1 addition & 1 deletion Test/public/addRepoIssueComment.test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function Test_GetRepoIssues_Success{

Reset-InvokeCommandMock

$owner = 'solidifycustomers' ; $repo = 'bit21' ; $attributes="number,title,url"
$owner = 'solidifycustomers' ; $repo = 'bit21' ; $attributes="number,title,state,url"

MockCall -Command "gh issue list -R $owner/$repo --json $attributes" -filename getIssueList.json

Expand Down
2 changes: 0 additions & 2 deletions public/getRepoAccess.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ function Test-RepoAccess{

$result = Invoke-MyCommandJson -Command TestUserAccess -Parameters $param 2> $null

$ret = $null -eq $result

if($null -eq $result){
"User $User has access to $Owner/$Repo" | Write-Verbose
$ret = $true
Expand Down
2 changes: 1 addition & 1 deletion public/setRepoProperties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ curl -L -s -H "Authorization: Bearer {token}" -X PATCH https://api.github.com/re
'@

Set-MyInvokeCommandAlias -Alias SetRepoProperty -Command $cmd
Set-MyInvokeCommandAlias -Alias getToken -Command "Get-UserToken"
Set-MyInvokeCommandAlias -Alias getToken -Command "gh auth token"

<#
.SYNOPSIS
Expand Down
Loading