-
Notifications
You must be signed in to change notification settings - Fork 164
RUN-3992 Improve docs about Aws ssm timeout #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request significantly improves the AWS SSM timeout documentation by expanding it from a brief configuration note into a comprehensive guide. The changes clarify timeout limits based on different authentication methods and execution types, provide better-organized configuration instructions, and add helpful best practices for timeout management.
Key Changes:
- Added detailed timeout limits documentation including authentication-specific maximums (12 hours with Assume Role, 48 hours without, 8 hours for inline scripts)
- Restructured configuration instructions into four clear methods with code block examples
- Added VuePress admonitions for important warnings and best practices about timeout configuration
- Cross-referenced the enhanced documentation from the cross-account AWS SSM tutorial
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/manual/projects/node-execution/aws-ssm.md | Expanded the "Execution Timeout Configuration" section with detailed limits, structured configuration methods using code blocks, and added warning/tip admonitions for best practices |
| docs/learning/howto/cross-account-aws-ssm.md | Added a tip box referencing the enhanced timeout documentation with a quick summary of timeout limits |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fdevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good update. Let's review the CoPilot comments about the timeout values.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Updates AWS SSM documentation to reflect configurable execution timeout feature https://github.com/rundeckpro/rundeckpro/pull/4537
This PR updates the AWS Systems Manager (SSM) Node Executor documentation to include the new configurable timeout functionality introduced in version 5.18.0.
Changes Made: