Use bottom_up in fuzzer template substitution#4769
Merged
automergerpr-permission-manager[bot] merged 3 commits intodevelopfrom Mar 14, 2025
Merged
Use bottom_up in fuzzer template substitution#4769automergerpr-permission-manager[bot] merged 3 commits intodevelopfrom
bottom_up in fuzzer template substitution#4769automergerpr-permission-manager[bot] merged 3 commits intodevelopfrom
Conversation
gtrepta
approved these changes
Mar 14, 2025
Contributor
gtrepta
left a comment
There was a problem hiding this comment.
LGTM, good catch. I recall picking top_down over bottom_up for performance reasons, I don't remember how I decided that and admittedly didn't test it.
4113224
into
develop
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
top_downwithbottom_upto avoid redundant traversals in replacement terms, improving performance for large terms. While replacement terms are usually not large, this change enables an optimization in komet that results in a 3x speedup.The optimization in komet works by embedding large configuration cells without variables directly into a replacement term. This prevents the substitution algorithm from needlessly traversing these large terms, significantly reducing overhead.