Fix init_mint caller macros (replicate unpacking errors) #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkcumming
approved these changes
Jan 23, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
I think we go with this for now. At some stage I suppose we will need to revert to calling the dispatch. Originally @Stevengre changed things for performance gain, but the idea was that we could replicate the setup that was happening after the instruction dispatch but prior to the call that processes the instruction. Since some functions are private and we can't replicate it the same we should revert back, but if we want to enjoy the potential performance benefits (not sure if there is any measurement of if things improved) for now that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
test_process_initialize_mint*proofs pass for SPL-token