When deserializing a Map into an enum, allow for ignored extra keys#22
Merged
rushmorem merged 3 commits intorushmorem:mainfrom Jan 21, 2025
Merged
Conversation
2 tasks
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deserializing an enum the Deserializer currently expects a map with a single key corresponding to the variant of the enum. This breaks deserialization of query results in surrealdb, as an
idkey is injected into the map in the returned data.This change modifies the enum deserialization logic to succeed if exactly one of all possible variants exists as a key in the map, regardless of any other data.