fix: allow empty Map to deserialize as unit #33
Open
Adjective-Object wants to merge 2 commits intorushmorem:mainfrom
Open
fix: allow empty Map to deserialize as unit #33Adjective-Object wants to merge 2 commits intorushmorem:mainfrom
Adjective-Object wants to merge 2 commits intorushmorem:mainfrom
Conversation
serde's ContentDeserializer allows empty Map to deserialize as unit `()`. This is needed for internally tagged enums where the variant payload is `()`. Reference: https://github.com/serde-rs/serde/blob/d17902059e77e371d8a7f83ff403f9e760b70f45/serde/src/private/de.rs#L1301-L1318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a series of small fixes bringing serde-content in line with serde's value visitor, to deal with edge-cases.
serde's ContentDeserializer allows empty Map to deserialize as unit
().This is needed for internally tagged enums where the variant payload is
().Reference: https://github.com/serde-rs/serde/blob/d17902059e77e371d8a7f83ff403f9e760b70f45/serde/src/private/de.rs#L1301-L1318