Fix link to doc_cfg docs in cargo book
#16404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-documenting-cargo-itself
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
weihanglo
reviewed
Dec 16, 2025
src/doc/src/reference/features.md
Outdated
| [regex-docs-rs]: https://docs.rs/regex/1.4.2/regex/#crate-features | ||
| [sccache]: https://github.com/mozilla/sccache/blob/0.2.13/README.md#build-requirements | ||
| [`doc_cfg`]: ../../unstable-book/language-features/doc-cfg.html | ||
| [`doc_cfg`]: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#doccfg-and-docauto_cfg |
Member
There was a problem hiding this comment.
#doccfg-and-docauto_cfg
Do we have this anchor?
Member
Author
There was a problem hiding this comment.
Not yet, but I don't really see a solution since CI for the stabilization will fail until this link is fixed... but it requires to have a wrong link in here until then.
src/doc/src/reference/features.md
Outdated
| [regex-docs-rs]: https://docs.rs/regex/1.4.2/regex/#crate-features | ||
| [sccache]: https://github.com/mozilla/sccache/blob/0.2.13/README.md#build-requirements | ||
| [`doc_cfg`]: ../../unstable-book/language-features/doc-cfg.html | ||
| [`doc_cfg`]: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#doccfg-and-docauto_cfg |
Member
There was a problem hiding this comment.
We use relative paths so versioned doc jumps to versioned doc.
Suggested change
| [`doc_cfg`]: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#doccfg-and-docauto_cfg | |
| [`doc_cfg`]: ../../rustdoc/write-documentation/the-doc-attribute.html#doccfg-and-docauto_cfg |
GuillaumeGomez
force-pushed
the
fix-doc_cfg-link
branch
from
c2dcf22 to
899771d
Compare
Member
Author
|
I simply removed the link, like that we don't need to some back and front between here and the Rust repository. |
weihanglo
approved these changes
Dec 16, 2025
Member
|
Failed test: failures:
---- cache_lock::mutate_then_download stdout ----
thread 'cache_lock::mutate_then_download' (6808) panicked at tests\testsuite\cache_lock.rs:15:5:
test did not finish within 10 attempts (1.0023997s total)
failures:
cache_lock::mutate_then_download
test result: FAILED. 3969 passed; 1 failed; 24 ignored; 0 measured; 0 filtered out; finished in 923.27s |
rustbot
removed
the
S-waiting-on-review
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 20, 2025
Update cargo submodule 13 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..3861f60f6b58f57524c0e7aab1f5c1ad83e35409 2025-12-13 16:29:21 +0000 to 2025-12-19 21:53:33 +0000 - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 21, 2025
Update cargo submodule 13 commits in e91b2baa632c0c7e84216c91ecfe107c37d887c1..3861f60f6b58f57524c0e7aab1f5c1ad83e35409 2025-12-13 16:29:21 +0000 to 2025-12-19 21:53:33 +0000 - fix(sbom): Don't set CARGO_SBOM_PATH when empty (like stable) (rust-lang/cargo#16419) - chore(ci): report-timings to upload HTML report (rust-lang/cargo#16416) - fix(report): get the same feature parity of `--timings` (rust-lang/cargo#16414) - fix(docs): Document the only possible values for DEBUG in build scripts (rust-lang/cargo#16413) - fix(log): emit fingeprint log also for no-rebuild unit (rust-lang/cargo#16408) - Fix link to `doc_cfg` docs in cargo book (rust-lang/cargo#16404) - Add best pratice for how to check in generated files (rust-lang/cargo#16405) - test: Use a larger default term width (rust-lang/cargo#16403) - Document more services and permissions of the cargo team (rust-lang/cargo#16402) - fix(new): Improve quality of package name error messages (rust-lang/cargo#16398) - feat(log): add more log events (rust-lang/cargo#16390) - chore: bump to 0.95.0; update changelog (rust-lang/cargo#16395) - Cache submodule into git db (rust-lang/cargo#16246) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for CI of rust-lang/rust#150055 to pass. Also: I used a full URL instead of a relative path to avoid this can kind of issues in the future since
cargois a submodule and not a subtree.