Skip to content

Conversation

@kornelski
Copy link
Contributor

This makes test helper functions point to the failing test, rather than internals of a function that did some checking.

@Eh2406
Copy link
Contributor

Eh2406 commented Mar 3, 2021

Good call.
@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2021

📌 Commit 3f7f094 has been approved by Eh2406

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 3, 2021
@bors
Copy link
Contributor

bors commented Mar 3, 2021

⌛ Testing commit 3f7f094 with merge 3886aaa6e2f00021ec3c5af70ba6cd464cf6eee7...

@bors
Copy link
Contributor

bors commented Mar 3, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2021
@kornelski
Copy link
Contributor Author

I don't get why the "homu" test failed. The log only shows:

Run exit 1
  exit 1
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Error: Process completed with exit code 1.

@Eh2406
Copy link
Contributor

Eh2406 commented Mar 3, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
@bors
Copy link
Contributor

bors commented Mar 3, 2021

⌛ Testing commit 3f7f094 with merge 61a31bc...

@bors
Copy link
Contributor

bors commented Mar 3, 2021

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing 61a31bc to master...

@bors bors merged commit 61a31bc into rust-lang:master Mar 3, 2021
@kornelski kornelski deleted the track-assert branch March 3, 2021 18:56
@ehuss ehuss added this to the 1.52.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants