Draft to support CI job on riscv64 self hosted #1059
Conversation
yuzibo
force-pushed
the
add-self-hosted-on-riscv64
branch
from
b174918 to
0e95c55
Compare
|
To address the issue. I left some comments on there, please review it also |
| rm -rf /tmp/.buildx-cache | ||
| mv /tmp/.buildx-cache-new /tmp/.buildx-cache | ||
| test-riscv64gc-native: |
There was a problem hiding this comment.
This is the best solution I can think of for easy maintenance of this separate job. Although I'm not satisfied with the riscv64 job occupying a separate block. It would be better under one block like Running on self hosted runner which has the same level with matrix block.?
There was a problem hiding this comment.
I think you could probably add this under the test block pretty easily since a lot of the jobs are shared. Setting os: [self-hosted, linux, riscv64] should work, and for any step that doesn't need to run you can add/update if: !contains(matrix.os, "self-hosted")
| mv /tmp/.buildx-cache-new /tmp/.buildx-cache | ||
| test-riscv64gc-native: | ||
| name: Build and test (riscv64gc-unknown-linux-gnu self-hosted, experimental) |
There was a problem hiding this comment.
Let us focus on riscv64gc-unknown-linux-gnu first and other target triple we will to also support, like rva23 triple.
The experimental tag as it is.
There was a problem hiding this comment.
Just starting with one is great 👍
| - name: Download musl source | ||
| run: | | ||
| sed -i 's|https://github.com/kraj/musl.git|https://community-ci.openruyi.cn/others/kraj-musl.git|g' ./ci/update-musl.sh |
There was a problem hiding this comment.
I hope these sed usages can be accepted in order to speed up the whole workflow. And this clearly demonstrates what we did.
There was a problem hiding this comment.
Is the speed difference that significant? I'd rather not use the mirrors if possible to reduce the possible points of failure or things that could get out of sync.
2 participants
No description provided.