-
Notifications
You must be signed in to change notification settings - Fork 322
Update allocator-api2 #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Build error in bumpalo encountered by CI is fixed in fitzgen/bumpalo#299 |
|
Just to be explicit, this is definitely a breaking change -- as the bumpalo failure demonstrates. |
|
Bumpalo fails without this change as well. |
|
But it is a breaking change for users who use allocator-api2 for hashbrown types, as they would need to upgrade their version. The minor version update is forced by new implementation |
That's really what I meant, as it's (implicitly) a public dependency. And this is fine for I admit I didn't look at what actually went wrong with bumpalo in particular. |
|
So here's what happened: rust-lang/rust#146826 seems to have broken bumpalo (fitzgen/bumpalo#296). This PR isn't directly related, but is just generally nice to have since we're likely to have a major version bump in the next release. |
|
This is essentially blocked until bumpalo bumps its allocator-api2 version. |
|
The PR for that is fitzgen/bumpalo#299, FWIW. Just so others don't have to search for it. |
New version fixes some inconsistencies with std