Use pkgconf instead of pkg-config for brew builds
#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
changed the title
pkgconf instead of pkg-conf for brew buildspkgconf instead of pkg-config for brew builds
Signed-off-by: Rui Chen <rui@chenrui.dev>
Contributor
|
LGTM. |
nirbheek
reviewed
Dec 20, 2024
…ew does not support it Signed-off-by: Rui Chen <rui@chenrui.dev>
nirbheek
reviewed
Dec 20, 2024
amyspark
reviewed
Dec 21, 2024
Co-authored-by: Nirbheek Chauhan <nirbheek.chauhan@gmail.com>
Co-authored-by: Amyspark <amy@amyspark.me>
sdroege
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On homebrew side, we have migrated to use
pkgconffor all core formulae and now have everyone usepkgconfrather thanpkg-config.pkg-configdependency in core tap Homebrew/brew#18843