-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Add licenses + Run cargo update
#133456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licenses + Run cargo update
#133456
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The run-make-support library was changed cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
Seems to be from rust-lang/hashbrown#586 - @RalfJung, is this expected? |
|
Yeah the next hashbrown update can only happen after the next bootstrap bump (which should happy tomorrow, according to schedule). |
|
is it possible to push psm update separately? psm@0.1.23 fails to build on aarch64-pc-windows-gnullvm due to regression, 0.1.24 contains a fix for that. see rust-lang/stacker#65 (comment) |
|
Yeah you can just land this without the hashbrown update. |
0f6b48c to
af702e5
Compare
|
Reverted hashbrown |
oh no, I meant it should be updated ASAP 😯 |
af702e5 to
83f202d
Compare
|
Ah 😁 Restored |
|
☔ The latest upstream changes (presumably #133694) made this pull request unmergeable. Please resolve the merge conflicts. |
83f202d to
41167c9
Compare
41167c9 to
868668e
Compare
|
A lot of updates but it looks reasonable. Let's get psm fixed. @bors r+ |
|
☀️ Try build successful - checks-actions |
|
Will rebase once psm update lands |
|
The psm update shouldn't conflict so let's try this again. @bors r+ |
|
Btw, were you planning on doing the cc update separately or leaving that to someone else? |
|
Ideally the cc update will happen through the weekly update job - a lot of the time when there's an issue a subsequent release fixes it with no manual tweaking |
Replaces #131311
try-job: dist-x86_64-linux
License changes:
unicode_ident1.0.14 introduces(MIT OR Apache-2.0) AND Unicode-3.0, butunicode_ident1.0.12 ((MIT OR Apache-2.0) AND Unicode-DFS-2016) is still in treeinstantand its license exception are no longer used