resolve: Partially convert ambiguous_glob_imports lint into a hard error

[petrochenkov]

I'm tired of this logic interfering with any attempts to fix or refactor glob imports.

The lint was implemented 2.3 years ago, and made deny-by-default and report-in-dependencies 4 months ago.

The removal is a bit over-eager because of one piece that wasn't implemented correctly (#113099 (comment)), but I want to look at the crater results.

Part of #114095.

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 446cb60 (446cb600aa4837dd6c513f14fa0d25a909b177d7, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

[petrochenkov]

@craterbot check

[craterbot]

👌 Experiment pr-149195 created and queued.
🤖 Automatically detected try build 446cb60
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-149195 is completed!
📊 2676 regressed and 6 fixed (741888 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt ↩

[nnethercote]

@petrochenkov: seems like a lot of regressions :( Should I review this?

[petrochenkov]

@petrochenkov: seems like a lot of regressions :( Should I review this?

Not yet.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[petrochenkov]

The largest part of the regressions are from openssl-0.10.*, it's a known issue that is addressed by #147984.
So this is blocked by #147984 now.
@rustbot blocked

[yaahc]

Correct me if I'm wrong on this one

@rustbot author

[rustbot]

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

• It's intentional.
• The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[petrochenkov]

@bors try

[obi1kenobi]

I have no opinion one way or the other on this PR, just noting that I found the change to rustdoc JSON surprising and felt it might be a correctness risk to downstream tools.

cc @aDotInTheVoid

View changes since this review

[obi1kenobi]

This seems like a surprising change and possibly like a regression to me.

A few things I don't quite understand:

• why m1 claims to be stripped but still returns the item
• why m2 has different behavior, not returning its item despite looking identical to m1

Based on the current rustdoc here (and ignoring that we run with private and hidden items documented), cargo-semver-checks and similar tools would determine that m1::f is pub and importable without ambiguity, since m2::f is not shown and therefore there's nothing to indicate ambiguity.

[petrochenkov]

This is something that needed to go together with #147984 actually, independently from this PR.
Ambiguous glob imports can now be used from other crates (even if under a lint), so effective visibilities tables need to mark them as reachable (otherwise you get various kinds of issues, e.g. MIR for those items not being encoded).
Rustdoc uses the same effective visibility tables too, so the new items appear in rustdoc output as well.

[petrochenkov]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: aea72be (aea72be7e5474dab7f3e28cea3e2e6cfa3d1c3fa, parent: d0835adc4e114eac911150b3692b830b5583223a)

[petrochenkov]

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt

[craterbot]

👌 Experiment pr-149195-3 created and queued.
🤖 Automatically detected try build aea72be
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-149195-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more