Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 7, 2026

To be merged once we get rid of homu. We should double-check that homu no longer has access to push to these branches (including main) after this is merged. We can also delete the try and auto branches after this is merged.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing crates-io
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/bors':
      Rulesets:
          Ruleset for main
            No changes
    📝 Editing repo 'rust-lang/rust':
      Environments:
        🔄 Update: bors
            Removing branches: auto, try

@Kobzol
Copy link
Member Author

Kobzol commented Jan 9, 2026

I don't think that there is any point in returning to homu now, so we can merge this.

@Kobzol Kobzol marked this pull request as ready for review January 9, 2026 20:39
@Mark-Simulacrum
Copy link
Member

I think we want to delete the branches before/after merging this, right? Then they will no longer be used at all because we have the "cannot create branch" protection as well.

I think before doing that we should try to double check that there's no AWS and/or GitHub state that references the branch name in OIDC or environment rules or similar, to avoid accidentally exposing credentials to some future creator of the branch name. I'm not sure if there's an authoritative way to do that unfortunately, but at minimum they should be removed from the bors environment (https://github.com/rust-lang/rust/settings/environments/5453059056/edit).

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Jan 10, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 10, 2026

This PR actually removes them from the bors environment, we can do that through team now :) Not sure about the OIDC stuff though, will check simpleinfra.

@Kobzol
Copy link
Member Author

Kobzol commented Jan 10, 2026

Haven't found any references in simpleinfra, I think/hope we migrated everything to the bors environment when we switched off rust-lang-ci last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants