Mongodb support

[vlefr]

Modification to support MongoDB database.

[dmishh]

Thanks! I'll review as soon as I have some free time

[Nyholm]

This looks good. Great feature. I see that you have created a separate yaml for MongoDB and the orm. That's great!

What is the purpose of the new setting class? May I suggest to use the same setting class and then move the orm/MongoDB configuration away from the annotation and in to a separate yaml?

I do also think it is a good idea to refactor the settingsManager into one BaseSettingManager and one manager for each db.

[vlefr]

Hi Nyholm,
It's good idea to refactor the settingsManager with a BaseSettingsManager. However i create another setting class to match with MongoDB pattern (i.e document class). More i use an owner property instead of ownerId.

[Nyholm]

May I suggest that you do create an interface for the setting. (And maybe an abstract class?)

• Dmishh\Bundle\SettingsBundle\Model\SettingInterface
• Dmishh\Bundle\SettingsBundle\Document\Setting
• Dmishh\Bundle\SettingsBundle\Entity\Setting

Now you have the SettingInterface and you should typehint on it in the setting managers.

[vlefr]

Ok i'll do updates asap :)

[Nyholm]

Hey @qliam
Do you have any updates on this PR?

[vlefr]

Hi @Nyholm ,
Sorry, i don't have enough time since my PR.

Bye

[rvanlaak]

This could be implode instead of json_encode I think? Rest of the code looks quite okay, but I've got no MongoDB experience to validate this.