This repository was archived by the owner on May 15, 2025. It is now read-only.
Fix for the Assassin bee crashing servers and sided RF / Energy bee issues#39
Open
mjevans wants to merge 6 commits intorwtema:masterfrom
Open
Fix for the Assassin bee crashing servers and sided RF / Energy bee issues#39mjevans wants to merge 6 commits intorwtema:masterfrom
mjevans wants to merge 6 commits intorwtema:masterfrom
Conversation
Fix bugs rwtema#22 rwtema#25 (do not work on source hive) Fix bugs rwtema#23 rwtema#37 (use canHandleBlock guard) (and my issue) DarkPacks/Crackpack-3#113 src/main/java/com/rwtema/careerbees/effects/EffectPower.java Fix rwtema#17 (work on any valid side, including 'internal' / null) and refactored to de-duplicate code
…ergyStorage API doesn't seem to mandate a way of checking the absolute addition per block, forcing us to check all / specific sides. Since CareerBees appear to have a policy of per block, not per side, I can't make any optimizations for the 'storage full' case.
…ead of a custom object. Some style re-works to more closely follow the single early return use in the codebase. General syntax cleanups to make early returns easier to spot.
…gestions discussed with sam-kirby
…ock pos, which broke the seemingly non-issue guard. The bug in question is still resolved by calling canHandleBlock, since that checks the target genome against the calling genome as it's only possible true result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping to make Bees fun and worth doing in packs that include your mod (especially when combined with Gendustry).
While fixing a server crashing bug with the Assassin bees, I also looked over the other currently open issues and made the Energy bee work with sided blocks (by checking the null/internal side, as well as all the others).
Please accept this contribution of code. As there isn't an existing license specified nor a contributor agreement to look at and since the additions are either purely derivative works or arguably the obvious way for someone skilled in the art to resolve the problem (and thus not fit for copyright alone): I grant non-revocable, transferable, non-exclusive (you have them, I have them for my contributions alone, etc) rights to the code that I have offered for addition in the combined work.
It should resolve the following bugs, and I have built and tested these locally in single player.
src/main/java/com/rwtema/careerbees/effects/EffectAssassin.java
Fix bugs #22 #25 (do not work on source hive)
Fix bugs #23 #37 (use canHandleBlock guard)
(and my issue) DarkPacks/Crackpack-3#113
src/main/java/com/rwtema/careerbees/effects/EffectPower.java
Fix #17 (work on any valid side, including 'internal' / null) and refactored to de-duplicate code