Fix XmlLexiconFormat: initialize XmlLexiconParser with config from the lexicon #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curufinwe
changed the title
curufinwe
approved these changes
Jan 27, 2026
larissakl
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #105 introduced different formats for the
Bliss::Lexicon. Before this change, the xml lexicon parser was initialized inBliss::Lexicon::loadviaLexiconParser parser(config, this);, so theconfigmember of the lexicon itself was passed in the constructor. After the PR, the parser was initialized viaXmlLexiconParser parser(Core::Application::us()->getConfiguration(), &lexicon), so the global application config gets passed instead. This means that when the lexicon is configured as usual in our setups, parameters such asnormalize-pronunciationdon't work properly and always resort to their default value.