Spn smearing #2

theHoHsiao · 2024-05-27T08:28:20Z

We implemented the Wuppertal smearing and APE smearing for both connected and disconnected measurements.

…ex numbers)

fzierler · 2024-06-03T09:51:26Z

Hi, as discussed with Paul, I found that the code here is actually slower than the one developed on top of the old HiRep code (using the old complex numbers). Specifically, I tested this code here and compared it to the one at https://github.com/fzierler/hirep-smear on DiaL3 for the connected measurements on a 64x16^3 lattice using the same input file and same flags in the Makefile. I find that the code here is about 50% slower. I don't know what could have caused this behaviour.

fzierler · 2024-07-18T12:28:52Z

Hi, I also tried to test this code for a source position different from (0,0,0,0). However, this leads to a failure of the Inverter on some of the configurations. Typically, this depends on the MPI partitioning and the specific machine (or maybe compiler). Further testing shows that this appears even without smearing in the conventional code for point sources.

I suggest we remove the option to place the source at an arbitrary point for the smearing code.

fzierler · 2024-08-09T14:06:02Z

Hi, currently this code does not measure the disconnected pieces because a function call to this measurement was lost, when I ported the code to the recent version of HiRep. I have fixed this by now and created PR for Paul's branch here: theHoHsiao#1

edbennett · 2024-09-26T10:36:44Z

Hi both, just returning to this now—should this PR be merged in its current state, or should it wait until theHoHsiao#1 has been merged?

fzierler · 2024-09-26T10:48:27Z

Hi Ed, please wait until theHoHsiao#1 is merged.

add missing call to smeared disconnected measurement

edbennett

Many thanks for this.

Is there any chance please that for each function that is introduced, a comment could be added at the top giving

A one-sentence description of what the function does, in more words than the function name
If not obvious, the meaning/purpose of any parameters.
A reference to a paper or textbook, including equation numbers, for definintions of this.

E.g. APE_smearing might get the comment:

/* Updates the global APE smeared gauge field
   by performing Nsmear steps of APE smearing.
   Each step is Eq. (5) of 0801.1165;
   smear_val here is $\alpha$ in the convention of the paper. */

This will hopefully mean that future people working on the code have a much easier time working out what each function does. I realise that most of the existing code doesn't do this, but I think it's a difficulty we've all had when reading it, so hopefully we can move in the direction of sparing others the same frustration.

theHoHsiao · 2024-12-20T12:49:55Z

Hi Ed,

Sure! The code was written long ago when I was still a master's degree student. I will write some descriptions for the functions I implemented.

Fabian, maybe after the Christmas break, could you take care of the parts related to the disconnected calculations? I should finish writing the descriptions by that time.

edbennett · 2024-12-20T13:09:45Z

Thanks! Tagging @fzierler in case he's not subscribed to the issue.

1. write descriptions for the function 2. define helper functions to increase readability 3. remove unused arguments `int color` in `smearing_function`

theHoHsiao · 2025-01-06T07:46:59Z

Hi @edbennett and @fzierler,

Happy New Year! I hope you had a great holiday.

I have added some comments for the relevant functions.
I also refactor the function, measure_smearing_source_sink, with two helper functions, create_smear_source_and_measure and smear_sink_and_measure, to improve the readability.

Please have a look at it in your own time. @fzierler, I am leaving you the comments for the disconnected part. Thanks.
Feel free to let me know if they still need any improvements.

edbennett

Many thanks Paul, those comments are really helpful. I've tagged the remaining functions that I think would benefit from some explanation.

edbennett · 2025-01-06T09:53:42Z

LibHR/Utils/suN_utils.c

 }
+
+
+void cooling_SPN(suNg* g_out, suNg* g_in, suNg* g_tilde, int cooling){


What does this function do? Are $g$, $\tilde{g}$, $B$, $S$, … defined in a paper that we can cite here?

I could not find any reference for the cooling method for the Sp(2N) gauge group. Do you recall any papers you took as a reference when computing the glueballs?

I wasn't heavily involved in that computation; @dvadacchino do you remember this, please?

Cooling for Sp(2N) follows the same logic as for SU(N). The logic is explained at pages 9-10 of https://arxiv.org/pdf/hep-lat/0404008, i.e. by using the beta=infinity limit of the cabibbo-marinari algorithm, and then using gram-schmidt for resymplecticization.

Okay. I will implement some more comments based on that paper.

I have added some comments for cooling_SPN and its relevant helper functions: subgrb, subgrb_tau, vmxsu2, and vmxsu2_tau.

edbennett · 2025-01-06T09:54:34Z

LibHR/Utils/suN_utils.c

+    }
+}
+
+void subgrb(int i1col, int i2col, suNgfull* B11, suNgfull* C11){


What does this function do? Is there a paper we can cite?

this picks a su(2) submatrix of the kind (A4) in https://arxiv.org/pdf/2010.15781 of an sp(2n) matrix

edbennett · 2025-01-06T09:54:39Z

LibHR/Utils/suN_utils.c

+    vmxsu2(i1col,i2col,B11,A11);
+}
+
+void vmxsu2(int i1, int i2, suNgfull* A, double complex B[4]){


What does this function do? Is there a paper we can cite?

This is vector matrix multiplication for su2 matrices

edbennett · 2025-01-06T09:55:00Z

LibHR/Utils/suN_utils.c

+    }
+}
+
+void subgrb_tau(int n1, int n2, suNgfull* B11, suNgfull* C11){


What does this function do? How is it different from subgrb? Is there a paper we can cite?

this picks a su(2) submatrix of the kind (A5) in https://arxiv.org/pdf/2010.15781 of an sp(2n) matrix

edbennett · 2025-01-06T09:55:14Z

LibHR/Utils/suN_utils.c

+    vmxsu2_tau(n1, n2, B11, A11);
+}
+
+void vmxsu2_tau(int n1, int n2, suNgfull* A, complex B[4]){


What does this function do? How is it different from vmxsu2? Is there a paper we can cite?

LibHR/Observables/avr_plaquette.c

edbennett · 2025-01-06T14:05:48Z

LibHR/Observables/meson_measurements.c

+}
+// So far, only implement the measurement for mesons at rest
+// The sources are not localised on any lattice site but spread out
+/* Smearing for disconnected pieces for singlets (FZ Jan. 2024)*/


Can this comment go into more detail (and possibly be formatted like the others introduced in this PR)?

@fzierler Fabian, can I leave this to you?

theHoHsiao · 2025-01-07T01:18:26Z

Hi Ed,

Thanks for the review. As you pointed out, there are some spelling typos, and I forgot to say that I am still working on the APE smearing part. I will improve them soon.

theHoHsiao and others added 7 commits May 27, 2024 08:58

add code for APE and Wuppertal smearing (does not compile - old compl…

04d38e2

…ex numbers)

switch over to new complex numbers

f7b3468

rename source-and-sink smearing measurement code

206a9a7

perform all sink smearing levels at once

133899e

add smeared volume sources, smearing for disconnected pieces

fddfcb1

add example input file for meson measurements with smearing

c1413d3

add missing call to smeared disconnected measurement

1b204b6

Merge pull request #1 from fzierler/spn_smearing_missing_disconnected

2337370

add missing call to smeared disconnected measurement

edbennett requested changes Dec 20, 2024

View reviewed changes

theHoHsiao added 6 commits January 6, 2025 15:18

add comments for Wuppertal smearing and helper function

160e19e

1. write descriptions for the function 2. define helper functions to increase readability 3. remove unused arguments `int color` in `smearing_function`

Update .gitignore

eccde86

refine comments

2e987b3

add comments

0588c22

refine comments

f5f55a6

refine comments

ab43caa

edbennett requested changes Jan 6, 2025

View reviewed changes

theHoHsiao added 4 commits January 9, 2025 17:48

correct typo

fc87d3c

add comments

de20a96

improving comments

0fdc72b

add comments for cooling_SPN and helper functions

a2baa3f

		}


		void cooling_SPN(suNg* g_out, suNg* g_in, suNg* g_tilde, int cooling){

Spn smearing #2

Are you sure you want to change the base?

Spn smearing #2

Uh oh!

Conversation

theHoHsiao commented May 27, 2024

Uh oh!

fzierler commented Jun 3, 2024

Uh oh!

fzierler commented Jul 18, 2024

Uh oh!

fzierler commented Aug 9, 2024

Uh oh!

edbennett commented Sep 26, 2024

Uh oh!

fzierler commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edbennett left a comment

Choose a reason for hiding this comment

Uh oh!

theHoHsiao commented Dec 20, 2024

Uh oh!

edbennett commented Dec 20, 2024

Uh oh!

theHoHsiao commented Jan 6, 2025

Uh oh!

edbennett left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvadacchino Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvadacchino Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theHoHsiao commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fzierler commented Sep 26, 2024 •

edited

Loading

dvadacchino Jan 29, 2025 •

edited

Loading

dvadacchino Jan 29, 2025 •

edited

Loading