Skip to content

Conversation

@dimpase
Copy link
Member

@dimpase dimpase commented Dec 11, 2025

various improvements, including correcting L3 cache size computation for Intel macOS machines,
see malb/m4ri#35

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Documentation preview for this PR (built with commit d555c34; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase dimpase requested review from malb and tobiasdiez December 11, 2025 18:19
@dimpase
Copy link
Member Author

dimpase commented Dec 12, 2025

strangely enough CI can't get the upstream tarball

@malb
Copy link
Member

malb commented Dec 14, 2025

Hi, not quite sure what my review should cover. Version number is correct, what else should I check for?

@dimpase
Copy link
Member Author

dimpase commented Dec 14, 2025

normally speaking, checking that it builds and the Sage interface passes relevant tests :-)

@malb
Copy link
Member

malb commented Dec 14, 2025

Doesn't the CI do that already? Sorry, not trying to be difficult here!

@dimpase
Copy link
Member Author

dimpase commented Dec 14, 2025

Doesn't the CI do that already? Sorry, not trying to be difficult here!

Our CI isn't very good in package upgrades

@malb
Copy link
Member

malb commented Dec 15, 2025

I compiled this branch and ran make ptest:

----------------------------------------------------------------------                                                                                                                                                                                            
src/bin/sage -t --warn-long 5.0 --random-seed=202317777364966127840445714391483130859 src/sage/misc/sagedoc.py  # 1 doctest failed
src/bin/sage -t --warn-long 5.0 --random-seed=202317777364966127840445714391483130859 src/sage/interfaces/gap_workspace.py  # 2 doctests failed
src/bin/sage -t --warn-long 5.0 --random-seed=202317777364966127840445714391483130859 src/sage/repl/interpreter.py  # 1 doctest failed                                                                                                                            
src/bin/sage -t --warn-long 5.0 --random-seed=202317777364966127840445714391483130859 src/sage/doctest/test.py  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 662.3 seconds
    cpu time: 4531.7 seconds
    cumulative wall time: 4121.9 seconds
Features detected for doctesting: conway_polynomials,cvxopt,database_cremona_mini_ellcurve,database_ellcurves,database_graphs,fpylll,gap_package_polycyclic,gfan,imagemagick,info,jupyter_sphinx,lrcalc_python,meson_editable,mpmath,nauty,networkx,numpy,palp,pdf
tocairo,pexpect,pillow,polytopes_db,pplpy,primecountpy,ptyprocess,pyparsing,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.braiding,sage.libs.ecl,sage.libs.flint,sage.libs.gap,sage.libs.homfly,sage.libs.linbox,sage.libs.m4ri,sage.li
bs.ntl,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modular,sage.modules,sage.numerical.mip,sage.plot,sage.rings.complex_double,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.polynomial.pbori
,sage.rings.real_double,sage.rings.real_mpfr,sage.schemes,sage.symbolic,scipy,singular,sphinx,sympy
make[2]: Entering directory '/home/malb/software/sage'
./tools/test-git-no-uncommitted-changes
Error: the git repo has uncommitted changes:
 D conftest.py

make[2]: *** [Makefile:258: test-git-no-uncommitted-changes] Error 1
make[2]: Leaving directory '/home/malb/software/sage'
make[1]: *** [Makefile:262: test] Error 2
make[1]: Leaving directory '/home/malb/software/sage'
make: *** [Makefile:278: ptest] Error 2

I gather the conftest.py business is unrelated. I ran all of those "failing" tests and they passed. Thus, I gather doctests passed (this is on an Ubuntu server x86_64.

@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants