Skip to content

Conversation

@user202729
Copy link
Contributor

@user202729 user202729 commented Dec 19, 2025

... using pari.

Someone who actually knows elliptic curve should review this.

Currently .gens() of elliptic curves over number fields is implemented using simon_two_descent. I come across this as simon_two_descent method for elliptic curves over ℚ get removed after a period of deprecation.

.gens() of elliptic curves over ℚ is implemented using pari.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 0dcbc7e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant