Skip to content

Make User checks optional and fix a problem posting to Django when CSRF is in use #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make User checks optional and fix a problem posting to Django when CSRF is in use #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions LoginProviders/SCLoginDialogController.j
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/

@import <AppKit/CPWindowController.j>
@import <AppKit/CPCookie.j>
@import "../AccountValidators/SCAccountValidator.j"

var DefaultLoginDialogController = nil,
Expand Down Expand Up @@ -211,8 +212,12 @@ SCLoginFailed = 1;
loginObject = {'username' : username, 'password' : password, 'remember' : shouldRemember},
request = [CPURLRequest requestWithURL:[[CPBundle mainBundle] objectForInfoDictionaryKey:@"SCAuthLoginURL"] || @"/session/"];

var csrfCookie = [[CPCookie alloc] initWithName:"csrftoken"];

[request setHTTPMethod:@"POST"];
[request setValue:@"application/json" forHTTPHeaderField:@"Content-Type"];
if ([csrfCookie value] != nil)
[request setValue:[csrfCookie value] forHTTPHeaderField:@"X-CSRFToken"];
[request setHTTPBody:[CPString JSONFromObject:loginObject]];
_loginConnection = [_connectionClass connectionWithRequest:request delegate:self];
_loginConnection.username = username;
Expand Down Expand Up @@ -301,6 +306,9 @@ SCLoginFailed = 1;
/* @ignore */
- (void)_checkUser
{
if ([[CPBundle mainBundle] objectForInfoDictionaryKey:@"SCAuthUserCheckURL"] == "disabled")
return;

[_userCheckSpinner setHidden:NO];

var request = [CPURLRequest requestWithURL:([[CPBundle mainBundle] objectForInfoDictionaryKey:@"SCAuthUserCheckURL"] || @"/user/") + [_userField stringValue]];
Expand Down