[qemu-usermode] Simplify safe syscall patches. #1
Conversation
| #define QEMU_H | ||
|
|
||
| -#include "hostdep.h" | ||
| +// #include "hostdep.h" |
There was a problem hiding this comment.
In case it is just remove that line. I would make sense to explain this better as this change applies to any use of qemu since it not only applies to sb2.
There was a problem hiding this comment.
Yes it's required, because it'll redirect the syscall to an assembly implementation otherwise and sb2 can't handle that. The explanation is in the spec file.
There was a problem hiding this comment.
Generally speaking, I'm a firm believer of the "there shouldn't be commented code" rule. But I think this just might be the exception. But I also think Thaodan has a point - not everyone is going to go read the spec file to find the explanation here. Replacing this with // #include "hostdep.h" commented out because sb2 handles syscalls going through c interface or something like that would make it clear. Bit this is all just nitpicking really.
|
Frajo ***@***.***> writes:
Yes it's required, because it'll redirect the syscall to an assembly implementation otherwise and sb2 can't handle that. The explanation is in the spec file.
It's worth to put it here since the code might be used without the spec
file and the context should be in the patch for rebasing etc.
|
|
LGTM, except for the WIP in title, and the nitpick about the commented out include |
After sailfishos/scratchbox2#21 is merged, we can now let syscalls go through the C syscall function.
krnlyng
changed the title
krnlyng
changed the title
3 participants
After sailfishos/scratchbox2#21
is merged, we can now let syscalls go through the C syscall
function.
DO NOT MERGE BEFORE:
sailfishos/scratchbox2#21