Don't enable all systemd flags for OpenRC#32
Open
tecknicaltom wants to merge 1 commit intosakaki-:masterfrom
Open
Don't enable all systemd flags for OpenRC#32tecknicaltom wants to merge 1 commit intosakaki-:masterfrom
tecknicaltom wants to merge 1 commit intosakaki-:masterfrom
Conversation
I know the comment says it's for future flexibility, but if switching from OpenRC to systemd, you're going to have to rebuild your kernel anyway. This moves the few systemd-specific kernel configs into a block that's only run if targetting systemd. The corresponding OpenRC block doesn't require any specific configs that I could determine, but left empty in case anything needs to be added in the future. I've built an OpenRC-based system with a clean kernel config with this and confirmed it works.
Owner
|
Is there any strong reason to drop the options that |
Owner
|
31 Oct 2020: sadly, due to legal obligations arising from a recent change in my 'real world' job, I must announce I am standing down as maintainer of this project with immediate effect. For the meantime, I will leave the repo up (for historical interest, and it may be of use to others); however, I plan no further updates, nor will I be accepting / actioning further pull requests or bug reports from this point. Email requests for support will also have to be politely declined, so, please treat this as an effective EOL notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know the comment says it's for future flexibility, but if switching
from OpenRC to systemd, you're going to have to rebuild your kernel
anyway. This moves the few systemd-specific kernel configs into a block
that's only run if targetting systemd. The corresponding OpenRC block
doesn't require any specific configs that I could determine, but left
empty in case anything needs to be added in the future. I've built an
OpenRC-based system with a clean kernel config with this and confirmed
it works.