Add :skip_prefix option to allow metrics without configured prefix#3
Add :skip_prefix option to allow metrics without configured prefix#3BondarenkoStas merged 2 commits intomasterfrom
Conversation
|
This change is used through the glia Metrics library. https://github.com/salemove/glia-elixir-utils/pull/56 Once merged, I'll have to create the 1.5.1 tag manually. I haven't tested the changes yet, though these are simple changes. I might need to merge these changes in order for me to use them on the Glia Metrics library so that I can test on an environment to see the metrics. |
zidik
left a comment
zidik
left a comment
There was a problem hiding this comment.
Approved on the condition that the comments are addressed
bautrey37
force-pushed
the
add-skip_prefix-option
branch
from
6b24019 to
c7cdece
Compare
|
@zidik I made the changes to your comments, but I'll be dropping this task. I don't have the time to thoroughly test this. I'll link it to this ticket. https://glia.atlassian.net/browse/QVA-1222 |
BondarenkoStas
force-pushed
the
add-skip_prefix-option
branch
2 times, most recently
from
0b6424d to
f810627
Compare
|
Hey @zidik, I rewrote it a bit (functionality didn't change), re-requested a review for a piece of mind :) |
is expected to fail https://my.slack.com/archives/CHN6UB7UH/p1768233057166119 |
|
Thanks @BondarenkoStas Call-router will definitively use this new functionality. |
| use Mix.Project | ||
|
|
||
| @version "1.4.0" | ||
| @version "1.5.1" |
There was a problem hiding this comment.
Call-router will definitively use this new functionality.
do you mean to remove GlobalStatix module and instead of no_namespace pass skip_prefix? Yes that's a great idea
There was a problem hiding this comment.
Yes, exactly!
We could make this option as no_namespace, if you prefer.
There was a problem hiding this comment.
I believe this is the reason why call-router is not on Erlang v26.
There was a problem hiding this comment.
I was thinking to just use it as no_namespace here, it won't be breaking since all the usage is salemove is just true/false with the same intent. But naming wise skip_prefix is right to the point as it's exactly what it does.
What do you think?
There was a problem hiding this comment.
I like skip_prefix because its clearer.
Also, the term prefix is already used in this metric library.
Adds support for a :skip_prefix option across all metric functions, allowing metrics to be sent without the configured prefix on a per-call basis. Useful for integrating with external systems or sending fully-qualified metric names to services that expect specific naming conventions. When skip_prefix: true is passed, the configured prefix is omitted from the metric packet. The option works with all metric types and combines with other options like tags and sample_rate. QVA-1222
BondarenkoStas
force-pushed
the
add-skip_prefix-option
branch
from
f810627 to
351066c
Compare
bautrey37
left a comment
bautrey37
left a comment
There was a problem hiding this comment.
I approve of the changes. Thanks @BondarenkoStas
4 participants
Adds support for a :skip_prefix option across all metric functions, allowing metrics to be sent without the configured prefix on a per-call basis. Useful for integrating with external systems or sending fully-qualified metric names to services that expect specific naming conventions.
When skip_prefix: true is passed, the configured prefix is omitted from the metric packet. The option works with all metric types and combines with other options like tags and sample_rate.
Will be included in https://github.com/salemove/glia-elixir-utils/pull/56
Which will be included in https://github.com/salemove/wrap-up-assistant/pull/672
QVA-1222