Skip certificate management if none given#14
Merged
gravyboat merged 1 commit intosaltstack-formulas:masterfrom Sep 2, 2016
Merged
Skip certificate management if none given#14gravyboat merged 1 commit intosaltstack-formulas:masterfrom
gravyboat merged 1 commit intosaltstack-formulas:masterfrom
Conversation
86a6dc8 to
79efc8e
Compare
|
Good stuff, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR fix?
If a certificate_authorities is configured by setting
ssl_cert_pathbut no certificate file exists atsalt://filebeat/files/ca.pem, thefile.managedstate infilebeat.configfails.Solution
This PR brings the possibility to disable the management of a logstash certificate authority file by setting
ssl_certtoNone:This is not the nicest solution to the problem, but it does not break existing configurations.
Additional Contents
This PR also adds the ability to disable using custom certificate_authorities, which is also attempted with #11, which seems to be dormant. To disable custom certificate_authorities, set
ssl_cert_pathtoNone: