Conversation
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: opencode:gpt-5.3-codex
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9db8f7b1b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| unsafe impl Send for SendFile {} | ||
| unsafe impl Sync for SendFile {} |
There was a problem hiding this comment.
The unsafe impl Send/Sync on SendFile bypasses wasm-bindgen’s thread-safety model for JS-backed handles; this becomes a real correctness risk when wasm threads are enabled or when a BlockReader future is moved across workers, because the underlying File/JsValue can then be accessed or dropped on a different thread than where it originated. In that environment this can panic or lead to undefined behavior, so this should be constrained to a proven single-thread runtime or redesigned to avoid cross-thread File sharing.
Useful? React with 👍 / 👎.
1 participant
No description provided.