Conversation
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: opencode:gpt-5.3-codex
|
@codex have a gander maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaate |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4a76f9aa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .write_all(input) | ||
| .with_context(|| format!("writing input to dtc for {context}"))?; |
There was a problem hiding this comment.
If dtc exits early (for example, malformed overlay input) stdin.write_all(input)? can return BrokenPipe, and this function returns immediately without calling wait* on the spawned child. In that error path the dtc process is left unreaped, so repeated failures can accumulate zombie children and eventually disrupt further CLI runs in long-lived sessions.
Useful? React with 👍 / 👎.
1 participant
No description provided.