Conversation
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: opencode:gpt-5.3-codex
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ad478475f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let terminal_rows = state.serial.styled_rows(inner_rows.max(1)); | ||
| let lines: Vec<Line<'_>> = terminal_rows |
There was a problem hiding this comment.
The TUI serial pane renders styled_rows(inner_rows) from a SerialTerminal that is created with the default 240 rows, but this code never calls set_size to match the panel height. That means the view is always taking the bottom rows of a much taller buffer, so early boot output (which starts near row 0) is not shown until roughly 240 lines have scrolled. In practice this hides the early serial logs this feature is meant to expose.
Useful? React with 👍 / 👎.
| Err(err) => { | ||
| on_event(NativeSerialEvent::Error(err)); | ||
| std::thread::sleep(selector.poll_interval); | ||
| continue; |
There was a problem hiding this comment.
When matching_port_path returns an error, the reader thread emits the error and immediately retries forever. On non-Linux hosts this function always returns "native serial reader is only implemented for Linux hosts", so enabling serial monitoring creates a permanent error loop (every poll interval) with continuous log spam and unnecessary background activity instead of failing once and stopping.
Useful? React with 👍 / 👎.
1 participant
No description provided.