feat(yaml): YAML command enhancements (Sprint 9.0) #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --dry-run flag to yaml-set and yaml-multiset commands that shows a preview of changes without actually modifying the YAML file. Supports --json and --min output modes for scripting.
Adds --quiet flag to yaml-set and yaml-multiset commands that suppresses success messages while still returning errors. Useful for scripting where only errors should be visible. Dry-run output is NOT suppressed by quiet mode since it's informational, not a success message.
Adds --required-file flag to yaml-multiget command that loads required keys from a file. Supports # comments (line and inline), empty lines, and whitespace trimming. Keys from file are combined with positional arguments and deduplicated while preserving order.
Updates MCP tool definitions and handlers for yaml_set, yaml_multiget, and yaml_multiset: - yaml_set: adds dry_run, quiet parameters - yaml_multiget: adds required_file parameter, keys no longer required - yaml_multiset: adds dry_run, quiet parameters - All: updated descriptions to mention bracket notation support
Security hardening: - Add path traversal protection to parseRequiredKeysFile (symlink rejection) - Add 10MB stdin size limit to prevent memory exhaustion - Add UTF-8 validation to reject binary data Edge case fixes: - Increase scanner buffer to 256KB for long YAML keys - Handle Windows line endings (\r\n) in stdin - Add read lock to dry-run mode to prevent race conditions Test coverage: - Add tests for yaml-set dry_run/quiet parameters - Add tests for yaml-multiset dry_run/quiet parameters - Add test for yaml-multiget required_file parameter Maintainability: - Replace magic number -999 with invalidArrayIndex constant
Database directory changes:
- Change default index directory from .llm-index to .index
- Make FTS database project-local at .index/qdrant_fts.db
- Remove global ~/.llm-semantic/ fallback for FTS
Memory stats tracking:
- Add memory_stats and retrieval_log tables to schema
- Add RetrievalStats, MemoryRetrieval, RetrievalLogEntry types
- Add MemoryStatsTracker interface for optional stats support
- Implement tracking in SQLiteStorage and LexicalIndex
- Auto-track retrievals in memory search (non-blocking)
- Add stats methods: Track, GetStats, GetHistory, Prune, UpdateStatus
New directory structure:
{gitRoot}/.index/
├── semantic.db # Main index (embeddings, chunks)
└── qdrant_fts.db # FTS index (project-local)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the yaml command family with 5 new features:
items[0].name, with negative index support (items[-1])-as the value argument--dry-run--quiet--required-fileChanges
yaml-set/yaml-multiset--dry-runflag to preview changes without writing--quietflag to suppress success output (errors still shown)yaml-get/yaml-multiget--required-fileflag to load keys from a file#comments in required keys filesMCP Tools
yaml_set,yaml_multiset,yaml_multigetwith new parametersTest Plan
Files Changed
internal/support/commands/yaml.go(+156 lines)internal/support/commands/yaml_helpers.go(+439 lines)internal/support/commands/yaml_test.go(+1119 lines)internal/support/mcpserver/handlers.go(+25 lines)internal/support/mcpserver/tools.go(+30 lines)internal/support/mcpserver/tools_test.go(updated required fields)