feat(semantic): Memory Stats CLI Command #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the memory stats CLI subcommand with table output display.
- Added memoryStatsCmd() function with all required flags
- Registered stats subcommand to memoryCmd()
- Implemented runMemoryStats() with mode routing
- Implemented runMemoryStatsTable() for default stats display
- Implemented runMemoryHistory() for retrieval history display
- Implemented runMemoryPrune() for log pruning
- Added formatDisplayDate() helper for date formatting
- Added truncateRuneAware() for UTF-8 safe text truncation
- Fixed adversarial findings: UTF-8 truncation, stdin error handling, older-than cap
Tests: Added TestMemoryStatsCmd_HasRequiredFlags, TestMemoryStatsCmd_RegisteredAsSubcommand,
TestMemoryStatsCmd_Flags, TestTruncateRuneAware with UTF-8 support
Add --json and --min flags to memory stats subcommand with output for: - runMemoryStatsTable: Full/min JSON with abbreviated keys - runMemoryHistory: Full/min JSON with memory details and history - runMemoryPrune: Full/min JSON with deletion count TDD: GREEN + ADVERSARIAL (1 LOW severity issue logged)
Fixes: - LOW: Remove JSON indent for --min output (compact JSON now actual min) - LOW: Preserve error type when wrapping memory not found error (%w) Deferred: - LOW: N+1 query pattern in GetAllMemoryStats (requires schema/interface changes)
- Add llm_semantic_memory_stats MCP tool wrapper - Fix code review findings (min-retrievals validation, JSON indent, error wrapping) - Update code review report with all fixes verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
llm-semantic memory statsCLI subcommand for retrieving statistics and managing memory entries, with full MCP tool parity.Key Deliverables
--idor minimum--min-retrievalsthreshold--historydisplays detailed retrieval timeline for a specific memory entry--prune --older-than <days>removes retrieval logs older than specified days--json) and minimal JSON (--min) for automationllm_semantic_memory_statsprovides full feature parity via MCP protocolSecurity Fixes
--min-retrievalsvalidation prevented--older-thanupper-bounded at 36,500 days (100 years)--minoutput%wverb for proper error unwrappingTest Plan
llm_semantic_memory_statstool