[dev] Use built-in Rails health check#2331
Merged
StephenHulme merged 3 commits intodevelopfrom Apr 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2331 +/- ##
===========================================
- Coverage 81.25% 81.25% -0.01%
===========================================
Files 478 477 -1
Lines 18511 18509 -2
Branches 278 278
===========================================
- Hits 15041 15039 -2
Misses 3468 3468
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
approved these changes
Apr 16, 2025
Contributor
BenTopping
left a comment
BenTopping
left a comment
There was a problem hiding this comment.
Nice looks good to me.
This reverts commit 834be95.
harrietc52
approved these changes
Apr 22, 2025
Contributor
harrietc52
left a comment
harrietc52
left a comment
There was a problem hiding this comment.
awesome, could we maybe roll this out for other Rails apps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/sanger/deployment/issues/543
Changes proposed in this pull request
Implements: https://edgeapi.rubyonrails.org/classes/Rails/HealthController.html
Instructions for Reviewers
Pairs well with #2330
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version