FIX - added uniq on id to prevent duplicates#2485
Open
andrewsparkes wants to merge 1 commit intodevelopfrom
Open
FIX - added uniq on id to prevent duplicates#2485andrewsparkes wants to merge 1 commit intodevelopfrom
andrewsparkes wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2485 +/- ##
========================================
Coverage 83.87% 83.88%
========================================
Files 499 499
Lines 20085 20085
Branches 384 384
========================================
+ Hits 16847 16848 +1
+ Misses 3234 3233 -1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Using uniq on the search results on the Limber side provides a workaround for duplicate results but the real problem is having duplicates in the search results on the Sequencescape side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request