2596y25-595---display plate id on prepool plate schematic#2693
2596y25-595---display plate id on prepool plate schematic#2693
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2693 +/- ##
===========================================
- Coverage 84.59% 84.56% -0.03%
===========================================
Files 501 501
Lines 20538 20545 +7
Branches 377 377
===========================================
Hits 17374 17374
- Misses 3161 3168 +7
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
It looks like we are already populating the plate barcode but it is just invisible as its black text on black background. See caption here https://github.com/sanger/limber/blob/develop/app/frontend/entrypoints/pages/multi_plate_pooling.js#L278 (line 278).
I think it would be best to add the input barcode in that caption too - should save you having to create those new html divs.
BenTopping
left a comment
There was a problem hiding this comment.
Changes look good to me - I have not tested locally.
Do we need tests for this?
BenTopping
left a comment
There was a problem hiding this comment.
Nice looks good to me.
…l-plate-schematic

Closes #
Changes proposed in this pull request
update the template and javascript to display plate barcode & input barcode on top of source plate
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version