Skip to content

2596y25-595---display plate id on prepool plate schematic#2693

Open
wendyyang wants to merge 9 commits intodevelopfrom
2596-y25-595---display-plate-id-on-prepool-plate-schematic
Open

2596y25-595---display plate id on prepool plate schematic#2693
wendyyang wants to merge 9 commits intodevelopfrom
2596-y25-595---display-plate-id-on-prepool-plate-schematic

Conversation

@wendyyang
Copy link
Contributor

Closes #

Changes proposed in this pull request

update the template and javascript to display plate barcode & input barcode on top of source plate

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.56%. Comparing base (69b9ec5) to head (39309bd).

Files with missing lines Patch % Lines
.../frontend/entrypoints/pages/multi_plate_pooling.js 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2693      +/-   ##
===========================================
- Coverage    84.59%   84.56%   -0.03%     
===========================================
  Files          501      501              
  Lines        20538    20545       +7     
  Branches       377      377              
===========================================
  Hits         17374    17374              
- Misses        3161     3168       +7     
  Partials         3        3              
Flag Coverage Δ
javascript 79.67% <0.00%> (-0.05%) ⬇️
pull_request 84.56% <0.00%> (-0.03%) ⬇️
push 84.56% <0.00%> (-0.03%) ⬇️
ruby 92.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are already populating the plate barcode but it is just invisible as its black text on black background. See caption here https://github.com/sanger/limber/blob/develop/app/frontend/entrypoints/pages/multi_plate_pooling.js#L278 (line 278).

I think it would be best to add the input barcode in that caption too - should save you having to create those new html divs.

@wendyyang wendyyang requested a review from BenTopping February 4, 2026 17:33
Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me - I have not tested locally.

Do we need tests for this?

@wendyyang
Copy link
Contributor Author

wendyyang commented Feb 5, 2026

Changes look good to me - I have not tested locally.

Do we need tests for this?

I run integration suite to test it, the screenshot looks like:

Screenshot_plate

Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-595 - Display Cherry Pick Plate ID and LB Lib PCR XP Unique ID on prepool plate schematic (ISC Pipeline)

2 participants