Skip to content

Y25-709 - Remove obsolete accessioning code#5484

Open
StephenHulme wants to merge 24 commits intodevelopfrom
y25-709-remove-obsolete-accessioning-code
Open

Y25-709 - Remove obsolete accessioning code#5484
StephenHulme wants to merge 24 commits intodevelopfrom
y25-709-remove-obsolete-accessioning-code

Conversation

@StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Jan 21, 2026

Closes #5420 and #4878

Changes proposed in this pull request

  • Remove y25_286_accession_individual_samples_with_sample_accessioning_job feature flag
  • Remove references to Accessionable::Sample
  • Remove references to accession_local_key and contact_user (see deployment PR)
  • Remove FakeAccessionService and references
  • Remove sample-accessioning-related Cucumber tests
  • Convert study-accessioning-related Cucumber tests to Rspec feature tests

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme added the Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. label Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.23%. Comparing base (cae30e7) to head (90e3a01).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5484      +/-   ##
===========================================
- Coverage    87.35%   87.23%   -0.13%     
===========================================
  Files         1462     1459       -3     
  Lines        32966    32851     -115     
  Branches      3461     3449      -12     
===========================================
- Hits         28796    28656     -140     
- Misses        4149     4174      +25     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay lots of deleting.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-709 - Remove obsolete accessioning code

3 participants