Open
Conversation
…or library asset types.
… sequencing source labware
…type assignment for library plates
…usting item retrieval
…broadcast_consumer
…t subject type assignment for library plates
…a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…re type for library plates
…n-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table' into y25-544-and-697
…-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…97---as-a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…n-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table' into 5382-y25-697---as-a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
…a-developer-ben-i-would-like-sample-manifest-library-assets-to-appear-in-the-stock_resource-table
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5511 +/- ##
========================================
Coverage 87.35% 87.35%
========================================
Files 1462 1462
Lines 32966 32966
Branches 3461 3461
========================================
Hits 28796 28796
Misses 4149 4149
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
reviewed
Feb 2, 2026
Contributor
BenTopping
left a comment
BenTopping
left a comment
There was a problem hiding this comment.
LGTM, couple small things.
Worth updating this comment https://github.com/sanger/sequencescape/blob/develop/app/sample_manifest_excel/sample_manifest_excel/upload/base.rb#L116 to avoid future confusion.
Is it worth testing stock_resource messages are sent for libraries here too https://github.com/sanger/sequencescape/blob/develop/spec/models/sample_manifest/uploader_spec.rb#L86. Seem to be a missing assertion for stock resources tests.
BenTopping
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5382
Changes proposed in this pull request
stock?method to return true forLibraryAsset.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version