Ensure sessions are always closed, even if the VM receives SIGINT. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will accomodate sessions left open due to exceptions and early termination of the VM. It does _not_ guarantee session closure due to native method malfunction or SIGKILL/TerminateProcess (due to Java not guaranteeing hook calls for these). This code runs all exit hooks at the default priority and may experience minor thread sharing issues with the WebDriver object.
Contributor
Author
|
Not entirely sure why there are two of these; Closing this in. favour of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will accomodate sessions left open due to exceptions and early termination of the VM.
It does not guarantee session closure due to native method malfunction or SIGKILL/TerminateProcess (due to Java not guaranteeing hook calls for these).
This code runs all exit hooks at the default priority and may experience minor thread sharing issues with the WebDriver object.