Skip to content

Conversation

@wjt5121
Copy link
Collaborator

@wjt5121 wjt5121 commented Jul 5, 2023

1 . Provides the automated tools to create simulation configurations and execute simulations against a Slurm cluster.
2. Additional Code for Azure Service Bus enabled Market Class

…ute simulations against a slurm cluster. Additional Code for Azure Service Bus enabled Market Class
@gitguardian
Copy link

gitguardian bot commented Jul 5, 2023

⚠️ GitGuardian has uncovered 15 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Microsoft Azure Storage Account Key fb0755d cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucas.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasShark.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasSharkStats.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/AMMPS_ONLY/slurmRunnerAMMPS.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key fb0755d cloud/automation/slurmRunner.py View secret
- GitHub Access Token fb0755d cloud/node_config/01-os-config-alma-linux.sh View secret
- Microsoft Azure Storage Account Key 3c80ca7 cloud/automation/simRunner.py View secret
- Microsoft Azure Storage Account Key 3c80ca7 cloud/automation/slurmRunner.py View secret
- GitHub Access Token 3c80ca7 cloud/node_config/01-os-config-alma-linux.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sbenthall
Copy link
Owner

Hello @wjt5121 Thanks for this. But GitGuardian is warning that there are secret keys in this PR, which is open to the public Internet.

Would it be possible to separate these out into a config file without the secrets in it, and then send us a config file with the real secrets in it?

You may also want to change the 'secrets' that have now been made public...

@wjt5121
Copy link
Collaborator Author

wjt5121 commented Jul 5, 2023

Oh yeah... duh... I totally forgot I had connection strings all over those run books. I've rotated the keys and will get it cleaned up and resubmit.
Thanks!!

@wjt5121
Copy link
Collaborator Author

wjt5121 commented Jul 6, 2023

Removed Secrets and updated runbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants