-
Notifications
You must be signed in to change notification settings - Fork 9
spacewar: 6.17 rebase #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sc7280-6.17.y
Are you sure you want to change the base?
spacewar: 6.17 rebase #14
Conversation
659a8ef to
7b449ba
Compare
DW9800 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Vitalii Skorkin <nikroksm@mail.ru>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Add support for ak7377 VCM, which has 10-bit position values, requiring a shift of 6 bits. It also has a different standby mode setting (0x10 instead of 0x40) and a significantly longer control delay. The maximum focus position is 1023, and the control step count is increased to 100. Tested on sm7325-nothing-spacewar phone. Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
It appears to sometimes take longer than two seconds for the tx_sdw_dev to appear, to increase the timeout. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
…r from DS This is some preparation for rewriting the driver: - Drop downstream pinctrl, point report check, gesture, pen, ESD, drm notifier implementation - Drop unused code - Drop old firmware files - Switch to tabs in main files - Refactor regulators & reset gpio implementation - Drop FTS macros & use kernel log func calls - And other minor changes... Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> Co-developed-by: Eugene Lepshy <fekz115@gmail.com>
Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
7b449ba to
f3420f7
Compare
| * pkt_per_line will be equal to slice per intf for now. | ||
| */ | ||
| pkt_per_line = slice_per_intf; | ||
| pkt_per_line = slice_per_intf * 2; // HACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you guard this under of_machine_is_compatible("nothing,spacewar")?
I assume https://lore.kernel.org/linux-arm-msm/20251001135914.13754-3-caojunjie650@gmail.com/ would be the proper fix? Do you know anything about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try if dongwoon,dw9800k (on the lists, but also in sc7280 6.17.y branch) works instead? Then we can drop this custom dw9800 driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, not sure if this version or https://lore.kernel.org/linux-arm-msm/20251009-ak7377-driver-v1-2-29e4f6e16ed3@fairphone.com/ is more correct. Do you have any extra insights there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JIaxyga Do you have any input here?
| compatible = "qcom,sm7325-lpassaudiocc", | ||
| "qcom,qcm6490-lpassaudiocc"; | ||
| /delete-property/ power-domains; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this with https://lore.kernel.org/linux-arm-msm/20250930-sc7280-dts-misc-v1-5-5a45923ef705@fairphone.com/, can drop this from sm7325.dtsi
| /delete-property/ power-domains; | ||
| }; | ||
|
|
||
| &lpass_cpu { status = "disabled"; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already disabled in sc7280.dtsi?
|
|
||
| &lpass_dmic23_data { | ||
| bias-pull-down; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure whether all this stuff, not just dmic should go into sm7325.dtsi or into the device itself.
It's per-se not really sm7325-specific, when an SM7325 device gets an Android 16 upgrade (looks like the Nothing phone 1 is already basically EOL, wtf?) the ADSP firmware from my understanding should be doing Audioreach instead of Elite, no q6afecc anymore. This opens a whole other can of worms, so not sure...
| #size-cells = <2>; | ||
| ranges; | ||
|
|
||
| bootargs = "clk_ignore_unused pd_ignore_unused"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
| "TX SWR_INPUT0", "ADC1_OUTPUT", // txmacro >= v9.2 | ||
| "TX SWR_INPUT1", "ADC2_OUTPUT", | ||
| "TX SWR_INPUT4", "ADC3_OUTPUT", | ||
| "TX SWR_INPUT5", "ADC4_OUTPUT"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean up this list?
|
|
||
| platform { | ||
| sound-dai = <&q6routing>; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetically: codec < cpu < platform
|
|
||
| platform { | ||
| sound-dai = <&q6routing>; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does microphone work by now? Last I heard it's broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the commit message for touchscreen commit to be fixup! $your_original_commit so it gets auto-squashed in the next rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to also add some options to fp5_defconfig, Alex also wants it renamed to sc7280_defconfig. Personally my muscle memory is already with fp5_defconfig ;)
Here is actual changes for nothing-spacewar. I created this PR as we have plan to merge our pmaports to postmarketos upstream.