Skip to content

spacewar: Add actuator support and fixup for sound patch #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JIaxyga wants to merge 3 commits into from
Closed

spacewar: Add actuator support and fixup for sound patch #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4957ed
WIP: media: i2c: Add dw9800 vcm driver
N1kroks Jan 22, 2025
f58dcff
sm7325-nothing-spacewar: Configure actuator for UW camera
JIaxyga Mar 6, 2025
edd81c8
fixup! arm64: dts: qcom: sm7325-nothing-spacewar: Add Mi2s sound support
JIaxyga Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,14 @@
};

&cci1_i2c0 {
/* actuator (For Rear-aux UW sensor) @ 0xc */
camu_dw9800w: actuator@c {
compatible = "dongwoon,dw9800w",
"dongwoon,dw9800";
reg = <0x0c>;

vin-supply = <&vreg_cam_vio_1p8>;
vdd-supply = <&vreg_camu_vaf_1p8>;
Copy link
Member

@z3ntu z3ntu Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My DW9800K only has a VDD pin (and VSS - whatever that does - is connected to ground, edit: nvm, VSS seems to just mean ground), what is VIN for you?

Copy link
Member

@z3ntu z3ntu Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product briefs for related ICs:

Copy link
Author

@JIaxyga JIaxyga Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downstream driver, as well as upstream driver of similar IC has both of these regulators

Copy link
Author

@JIaxyga JIaxyga Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dw9800w: https://github.com/Moto-MT6879-Dev/kernel_motorola_mt6879/blob/14/drivers/misc/mediatek/lens/vcm/v4l2/dw9800w/dw9800w.c#L46
dw9800v: https://github.com/Moto-MT6879-Dev/kernel_motorola_mt6879/blob/14/drivers/misc/mediatek/lens/vcm/v4l2/dw9800v/dw9800v.c#L51

dw9768: https://github.com/sc7280-mainline/linux/blob/sc7280-6.13.y/drivers/media/i2c/dw9768.c#L95

Copy link
Member

@z3ntu z3ntu Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream:

  • dw9714: vcc-supply
  • dw9719: vdd-supply
  • dw9768: vin-supply & vdd-supply
  • dw9807: no regulator support

But since the dw9800 in all its variants I have seen only has vdd, this should mean only vdd-supply should be added to driver/dt-bindings

};

camera@2d {
compatible = "samsung,s5kjn1";
Expand All @@ -950,6 +957,8 @@
orientation = <1>; /* Rear facing */
rotation = <90>;

lens-focus = <&camu_dw9800w>;

port {
camera_s5kjn1_ep: endpoint {
data-lanes = <1 2 3 4>;
Expand Down Expand Up @@ -1384,7 +1393,7 @@

&sound {
compatible = "qcom,sm7325-sndcard",
"qcom,qcm6490-idp-sndcard";
"qcom,sm8250-sndcard";

model = "NP1";

Expand Down
12 changes: 12 additions & 0 deletions drivers/media/i2c/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,18 @@ config VIDEO_DW9768
capability. This is designed for linear control of
voice coil motors, controlled via I2C serial interface.

config VIDEO_DW9800
tristate "DW9800 lens voice coil support"
depends on I2C && VIDEO_DEV
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_ASYNC
help
This is a driver for the DW9800 camera lens voice coil.
DW9800 is a 10 bit DAC with 100mA output current sink
capability. This is designed for linear control of
voice coil motors, controlled via I2C serial interface.

config VIDEO_DW9807_VCM
tristate "DW9807 lens voice coil support"
depends on I2C && VIDEO_DEV
Expand Down
1 change: 1 addition & 0 deletions drivers/media/i2c/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ obj-$(CONFIG_VIDEO_DS90UB960) += ds90ub960.o
obj-$(CONFIG_VIDEO_DW9714) += dw9714.o
obj-$(CONFIG_VIDEO_DW9719) += dw9719.o
obj-$(CONFIG_VIDEO_DW9768) += dw9768.o
obj-$(CONFIG_VIDEO_DW9800) += dw9800.o
obj-$(CONFIG_VIDEO_DW9807_VCM) += dw9807-vcm.o
obj-$(CONFIG_VIDEO_ET8EK8) += et8ek8/
obj-$(CONFIG_VIDEO_GC0308) += gc0308.o
Expand Down
Loading