Refactor model constructors to remove logger and context #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and extracting it from the ctx. Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
…ructor, update related methods to accept ctx as parameter Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
…ructor, update related methods to accept ctx as parameter Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
…x, update related methods to accept ctx as parameter Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
…ructor, update related methods to accept ctx as parameter Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
…tests accordingly Signed-off-by: Agustin Isasmendi <agustin.isasmendi@scanoss.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies multiple model constructors by removing the
loggerandctxparameters. The related methods are updated to acceptctxas a parameter where needed. Changes include updates to the following models:VersionModelProjectModelLicenseModelAllUrlsModel